Implemented rotate image feature #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I think we should just stick to one new field. orientation and localOrientation seem to be the same, so we should just stick with orientation and only save it when the setting says so. |
|
I think I can do that but I would need to disable the rotation made by the image library and apply the rotation myself. That way there will be less chances of de-sync of the variables. Also when the user setting to save tags on the files is changed should all photos be updated or the idea is to have them save the tags only when modified after the settings change? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #856
The
orientationfield contains the "Orientation" tag present in the file (if not present it will default to 1).The
localOrientationfield is used to rotate the thumbnail without writing into the original file (by default is one).Both use the EXIF orientation standard (numbers form 1 to 8) to describe how the image should be rotated.
The app by default rotates the thumbnails using the
localOrientationfield.If the users wants to save the tags to the image, the
orientationfield is used and it is written into the file itself. Most (if not all) image viewers will see that tag and rotate the image accordly. This method is non-destructive on the images as this is a loseless rotation (the image doesn't get re-encoded).The
api/photosedit/rotateendpoint has been added and it accepts POST requests passing:image_hash: The hash of the image that needs to be rotatedangle: A number that is a multiple of 90, that the image will be rotated by. If the number is negative the rotation will be counter-clockwiseflip: If the image should be filp (can be omitted, the default is false)